Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable local deploy of the arm64 ServiceHub project #69200

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

jasonmalinowski
Copy link
Member

This should address some reports where local F5 debugging fails when we try to deploy two different projects to the same place at once. I also rename the one ServiceHub package, so if by accident something were to get deployed twice it'll be clearer what is going on.

@jasonmalinowski jasonmalinowski requested a review from a team as a code owner July 25, 2023 01:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 25, 2023
@jasonmalinowski jasonmalinowski changed the title Disable local deploy of the arm64 ServiceHub binary Disable local deploy of the arm64 ServiceHub project Jul 25, 2023
@jasonmalinowski jasonmalinowski self-assigned this Jul 25, 2023
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix looks good to me. Pls fix the XML comment error.

This should address some reports where local F5 debugging fails when
we try to deploy two different projects to the same place at once. I
also rename the one ServiceHub package, so if by accident something
were to get deployed twice it'll be clearer what is going on.
@jasonmalinowski
Copy link
Member Author

Pls fix the XML comment error.

@genlu
You Didn't See Anything

@jasonmalinowski jasonmalinowski merged commit 387b6fb into dotnet:main Jul 25, 2023
24 checks passed
@jasonmalinowski jasonmalinowski deleted the fix-deployment-race branch July 25, 2023 17:14
@ghost ghost added this to the Next milestone Jul 25, 2023
@CyrusNajmabadi
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants