-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "use collection initializer" to use a collection-expression if the user prefers that form. #69219
Merged
CyrusNajmabadi
merged 44 commits into
dotnet:main
from
CyrusNajmabadi:useCollectionExpression2
Jul 28, 2023
Merged
Update "use collection initializer" to use a collection-expression if the user prefers that form. #69219
Changes from 33 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
873f289
Extract helper code
CyrusNajmabadi 1903cf4
Add tests
CyrusNajmabadi 6882edd
crlf
CyrusNajmabadi c1bb50f
Compiling
CyrusNajmabadi e278ebf
in progress
CyrusNajmabadi 60bf4c1
In progrss
CyrusNajmabadi e96f926
Building
CyrusNajmabadi 424722a
Rename
CyrusNajmabadi 95f1180
Rename
CyrusNajmabadi c9ad1ad
Rename
CyrusNajmabadi 8da263d
Fixes
CyrusNajmabadi 04899dc
Test fixes
CyrusNajmabadi 0681c8d
In progrss
CyrusNajmabadi 594a61c
Merge branch 'useCollectionExpression' into useCollectionExpression2
CyrusNajmabadi 503a97f
Merge branch 'useCollectionExpression' into useCollectionExpression2
CyrusNajmabadi f738836
Fixes
CyrusNajmabadi ca91efd
Add suppression
CyrusNajmabadi 57cdd67
updates
CyrusNajmabadi 419565e
Revert
CyrusNajmabadi 1e97397
Fixes
CyrusNajmabadi 9120941
tweak
CyrusNajmabadi ea38ef0
In progress
CyrusNajmabadi 361487a
In progress
CyrusNajmabadi 3b43bb2
In progress
CyrusNajmabadi f4fd927
in progress
CyrusNajmabadi a13673f
Mostly working
CyrusNajmabadi 7072918
Improvements
CyrusNajmabadi 59db01a
Improvements
CyrusNajmabadi a452a0c
Merge remote-tracking branch 'upstream/main' into useCollectionExpres…
CyrusNajmabadi 9932551
Add test
CyrusNajmabadi bb6702c
Add test
CyrusNajmabadi b93d46c
Share codE
CyrusNajmabadi 8dcaadf
Update src/Analyzers/CSharp/CodeFixes/UseCollectionInitializer/CSharp…
CyrusNajmabadi b0c9195
Self documenting
CyrusNajmabadi 3a9c5bb
Simplify
CyrusNajmabadi 9f8bcf2
Merge branch 'useCollectionExpression2' of https://github.com/CyrusNa…
CyrusNajmabadi 560a123
REstore
CyrusNajmabadi 3d629fb
REstore
CyrusNajmabadi acd85e5
Add comments
CyrusNajmabadi 8f4bfd7
simplify
CyrusNajmabadi 640dd0f
simplify
CyrusNajmabadi cbf06f5
simplify
CyrusNajmabadi 1d75e4d
Apply suggestions from code review
CyrusNajmabadi d65ce70
Merge remote-tracking branch 'upstream/main' into useCollectionExpres…
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code moved to helper type since it will be used by a lot more analyzers. basically, it's the code that says "could i use a collection literal here".