Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and clarify the logic when speculatively comparing old/new code to ensure semantics are the same. #69261

Merged
merged 11 commits into from
Jul 28, 2023

Merge branch 'main' into speculativeConversions

ea543bf
Select commit
Loading
Failed to load commit list.
Merged

Improve and clarify the logic when speculatively comparing old/new code to ensure semantics are the same. #69261

Merge branch 'main' into speculativeConversions
ea543bf
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Jul 28, 2023 in 0s

.NET Result Analysis

Details

Build Failures

roslyn-integration-corehost / VS_Integration_CoreHost_Debug / Build and Test

[:construction: Report infrastructure issue] [:page_facing_up: Report repository issue]
    ❌Server Error 502 - Web server received an invalid response while acting as a gateway or proxy server. There is a problem with the page you are looking for, and it cannot be displayed. When the Web server (while acting as a gateway or proxy) contacted the upstream content server, it received an invalid response from the content server.

Test Failures (5 tests failed)

[All failing tests from roslyn-integration-corehost][All failing tests from roslyn-integration-CI]

⚠️ 2 test failures are not displayed due to space limitations.

❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNavigateTo.NavigateTo [Details] [100.00% failure rate]
[:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

Failing Configurations (2)

  • 1-Integration Debug OOP64_true OOPCoreClr_true
  • 2-Integration Debug OOP64_true OOPCoreClr_true
Data Driven SubResults
    Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNavigateTo.NavigateTo (VS2022)
    Exception Message
    Assert.IsAssignableFrom() Failure
    Expected: typeof(System.Windows.Controls.Control)
    Actual:   (null)
    Stack Trace
       at Microsoft.VisualStudio.Extensibility.Testing.ShellInProcess.<>c__DisplayClass0_0.<<ShowNavigateToDialogAsync>b__1>d.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs:line 49
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()
       at Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run(Func`1 asyncMethod)
       at Microsoft.VisualStudio.Extensibility.Testing.ShellInProcess.<<ShowNavigateToDialogAsync>g__WaitForNavigateToFocusAsync|0_0>d.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs:line 46
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at Microsoft.VisualStudio.Extensibility.Testing.ShellInProcess.<ShowNavigateToDialogAsync>d__0.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs:line 35
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNavigateTo.<NavigateTo>d__3.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpNavigateTo.cs:line 41
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNavigateTo.<NavigateTo>d__3.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpNavigateTo.cs:line 65
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
❌ Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicNavigateTo.NavigateTo [Details] [13.14% failure rate]
[:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

Failing Configurations (2)

  • 1-Integration Debug OOP64_true OOPCoreClr_true
  • 2-Integration Debug OOP64_true OOPCoreClr_true
Data Driven SubResults
    Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicNavigateTo.NavigateTo (VS2022)
    Exception Message
    Assert.IsAssignableFrom() Failure
    Expected: typeof(System.Windows.Controls.Control)
    Actual:   (null)
    Stack Trace
       at Microsoft.VisualStudio.Extensibility.Testing.ShellInProcess.<>c__DisplayClass0_0.<<ShowNavigateToDialogAsync>b__1>d.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs:line 49
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()
       at Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run(Func`1 asyncMethod)
       at Microsoft.VisualStudio.Extensibility.Testing.ShellInProcess.<<ShowNavigateToDialogAsync>g__WaitForNavigateToFocusAsync|0_0>d.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs:line 46
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at Microsoft.VisualStudio.Extensibility.Testing.ShellInProcess.<ShowNavigateToDialogAsync>d__0.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs:line 35
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicNavigateTo.<NavigateTo>d__3.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicNavigateTo.cs:line 50
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAutomaticBraceCompletion.Nested_AllKinds [Details] [5.27% failure rate]
[:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

Failing Configuration

  • 1-Integration Debug OOP64_true OOPCoreClr_false
Data Driven SubResults
    Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAutomaticBraceCompletion.Nested_AllKinds(showCompletionInArgumentLists: True) (VS2022)
    Exception Message
    Assert.False() Failure
    Expected: False
    Actual:   True
    Stack Trace
       at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAutomaticBraceCompletion.<Nested_AllKinds>d__21.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpAutomaticBraceCompletion.cs:line 478
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
2 other tests are failing: [All failing tests from roslyn-integration-corehost] [All failing tests from roslyn-integration-CI]

Was this helpful? Yes No