Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use UICulture instead of Culture #69305

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 1, 2023

I messed this up in the original PR - we were setting the CurrentUICulture (correct), but reading the fallback from CurrentCulture. Fixed to also read from CurrentUICulture

@dibarbet dibarbet requested a review from a team as a code owner August 1, 2023 00:41
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 1, 2023
@dibarbet dibarbet enabled auto-merge August 1, 2023 01:00
@dibarbet dibarbet merged commit 4f5128d into dotnet:main Aug 1, 2023
22 of 24 checks passed
@ghost ghost added this to the Next milestone Aug 1, 2023
@dibarbet dibarbet deleted the fix_lsp_culture branch August 1, 2023 18:35
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants