Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzer conflicts on Linux #69406

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Fix analyzer conflicts on Linux #69406

merged 6 commits into from
Aug 9, 2023

Commits on Aug 4, 2023

  1. Fix analyzer conflicts on Linux

    This changes analyzer loading on Linux to be per user where before
    clashes could occur in the temp directory.
    
    This fix initially started out by making our temp directory logic more
    robust. Essentially add per user sub directories, do extended permission
    checks, etc ... That exacerbated a number of existing corner cases in
    the code and forced us to put a lot more error handling into the
    workspaces layer.
    
    After discussion with the IDE team I decided to take the approach of
    loading from a `Stream` on non-Windows platforms. The performance
    difference is neglible (1ms to 2ms per assembly) and it removes the
    overhead of copying them around on disk as well as the complexities that
    come with managing the shadow copy directory.
    
    This will be observable to any analyzer that used `Assembly.Location` as
    it will now be `""`. That is only useful though for inspecting disks
    which is already illegal for analyzers hence it's considered an
    acceptable break.
    
    closes dotnet#65415
    Jared Parsons committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9760b22 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. more

    Jared Parsons committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1249be8 View commit details
    Browse the repository at this point in the history
  2. PR feedback

    jaredpar committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    30920a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. PR feedback

    Jared Parsons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    02652a8 View commit details
    Browse the repository at this point in the history
  2. PR feedback

    jaredpar committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8ad2451 View commit details
    Browse the repository at this point in the history
  3. PR feedback

    jaredpar committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    7cff172 View commit details
    Browse the repository at this point in the history