IDE changes for analyzer loading #69470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For dotnet#69406 I updated several places where the IDE created analyzers. Even though I specifically called out the PR to the IDE team, I forgot I'd changed their code and merged once I had two compiler sign offs. This PR is commenting the parts of the IDE I changed in the PR so I can get actual sign off on these changes.
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
src/Tools/ExternalAccess/OmniSharp/Analyzers/OmnisharpAnalyzerLoaderFactory.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Diagnostics/DefaultAnalyzerAssemblyLoaderService.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Remote/ServiceHub/Host/RemoteAnalyzerAssemblyLoader.cs
Outdated
Show resolved
Hide resolved
|
@RikkiGibson, @cston, @jjonescz PTAL. Small changes from previous PR based on IDE feedback. The diff isn't rendering the best. Suggest looking at the current state of the file. It's a fairly simple change, just diff isn't rendering well. |
cston
approved these changes
Aug 11, 2023
RikkiGibson
approved these changes
Aug 11, 2023
jjonescz
approved these changes
Aug 14, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #69406 I updated several places where the IDE created analyzers. Even though I specifically called out the PR to the IDE team, I forgot I'd changed their code and merged once I had two compiler sign offs. This PR is commenting the parts of the IDE I changed in the PR so I can get actual sign off on these changes.