Fix some issues with the MSBuild NuGet packaging #69835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasonmalinowski
commented
Sep 6, 2023
jasonmalinowski
commented
- We were including the BuildHost executable but not the PDB, which we expect to do for symbol archiving.
- Since we had a regular project reference to the BuildHost, we were including a reference to the BuildHost NuGet package...which doesn't actually exist.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
commented
Sep 6, 2023
| @@ -23,7 +23,7 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <ProjectReference Include="..\..\..\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj" /> | |||
| <ProjectReference Include="..\MSBuild.BuildHost\Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.csproj" /> | |||
There was a problem hiding this comment.
Unfortunately NuGet doesn't give another way to opt out of this -- there's a TODO tracking what I actually want:
This was referenced Sep 6, 2023
jasonmalinowski
changed the title
jasonmalinowski
force-pushed
the
fix-nuget-packaging-issues
branch
from
43f86af
to
398e163
Compare
dibarbet
approved these changes
Sep 6, 2023
jasonmalinowski
force-pushed
the
fix-nuget-packaging-issues
branch
from
398e163
to
f34a879
Compare
jasonmalinowski
force-pushed
the
fix-nuget-packaging-issues
branch
2 times, most recently
from
1518a1b
to
a0acb8e
Compare
- We were including the BuildHost executable but not the PDB, which we expect to do for symbol archiving. - Since we had a regular project reference to the BuildHost, we were including a reference to the BuildHost NuGet package...which doesn't actually exist.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.