Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/source-build-externals #69870

Merged
merged 5 commits into from
Sep 12, 2023
Merged

[main] Update dependencies from dotnet/source-build-externals #69870

merged 5 commits into from
Sep 12, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 9, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-externals

  • Subscription: 1cf93f77-b43f-4032-fa6b-08d9301a7519
  • Build: 20230912.1
  • Date Produced: September 12, 2023 1:56:07 PM UTC
  • Commit: 5a3e6274a3749c3e6f8b2b3a01e6b42960687e86
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-exter…
a98b2eb 
…nals build 20230908.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23456.1 -> To Version 8.0.0-alpha.1.23458.1
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner September 9, 2023 12:11
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 9, 2023
ghost
ghost approved these changes Sep 9, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-exter…
e49ddec 
…nals build 20230908.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23456.1 -> To Version 8.0.0-alpha.1.23458.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-exter…
f778627 
…nals build 20230908.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23456.1 -> To Version 8.0.0-alpha.1.23458.1
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2023
Open
3 tasks
@mthalman
Copy link
Member

@jasonmalinowski - This is failing in source-build for some reason attempting to compile with the new Microsoft.Build.Locator version that's provided by source-build-externals.

@mthalman
Copy link
Member

Here's the error:

/__w/1/s/artifacts/source-build/self/src/src/Workspaces/Core/MSBuild.BuildHost/BuildHost.cs(12,23): error CS0234: The type or namespace name 'Locator' does not exist in the namespace 'Microsoft.Build' (are you missing an assembly reference?) [/__w/1/s/artifacts/source-build/self/src/src/Workspaces/Core/MSBuild.BuildHost/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.csproj]

The call to run csc isn't even passing a Microsoft.Build.Locator.dll as an argument. This happens for the net7.0 build. It's not there because the package is only being produced for net8.0: https://github.com/dotnet/source-build-externals/blob/f379c3367804237751f13311b5dddbfafc86be40/patches/MSBuildLocator/0002-Move-to-net8.patch#L19

@mthalman mthalman mentioned this pull request Sep 11, 2023
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-exter…
ad41e3a 
…nals build 20230911.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23456.1 -> To Version 8.0.0-alpha.1.23461.2
@mthalman mthalman mentioned this pull request Sep 12, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-exter…
85cd6b8 
…nals build 20230912.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23456.1 -> To Version 8.0.0-alpha.1.23462.1
@mthalman mthalman enabled auto-merge (squash) September 12, 2023 16:45
@mthalman mthalman merged commit 7639624 into main Sep 12, 2023
27 of 28 checks passed
@ghost ghost added this to the Next milestone Sep 12, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-eb59a84c-8758-4582-9f9a-55958527602f branch September 12, 2023 19:26
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
2 participants
@mthalman @Cosifne