Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SBRP dependency #69901

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Update SBRP dependency #69901

merged 1 commit into from
Sep 13, 2023

Conversation

mthalman
Copy link
Member

The SBRP dependency is out of date by 5 months. This updates it in order to have access to System.Text.Json.7.0.3. This fixes the issue of that showing up as a source-build prebuilt.

Contributes to #69847

@mthalman mthalman requested a review from a team as a code owner September 12, 2023 13:59
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 12, 2023
@ViktorHofer
Copy link
Member

Shouldn't roslyn have a subscription from source-build-reference-packages?

@mthalman
Copy link
Member Author

Shouldn't roslyn have a subscription from source-build-reference-packages?

Seems like it should. I'm having darc issues preventing me from adding a subscription for some reason. Can someone else do it? I'm thinking it should mirror the config of source-build-externals:

https://github.com/dotnet/source-build-externals (.NET 8) ==> 'https://github.com/dotnet/roslyn' ('main')
  - Id: 1cf93f77-b43f-4032-fa6b-08d9301a7519
  - Update Frequency: EveryDay
  - Enabled: True
  - Batchable: False
  - PR Failure Notification tags:
  - Merge Policies:
    AllChecksSuccessful
      ignoreChecks =
                       [
                         "WIP",
                         "license/cla"
                       ]
  - Last Build: 20230906.1 (1b64d3c0fad8af67da8f42927ce7306730224c15)

@ViktorHofer
Copy link
Member

Created

@mthalman
Copy link
Member Author

@dotnet/roslyn-infrastructure - This is hitting a seemingly known test failure that I believe is unrelated to these changes. PTAL and merge if good. This helps to unblock dependency flow: dotnet/installer#17319

@jaredpar jaredpar merged commit 0959e07 into dotnet:main Sep 13, 2023
25 of 27 checks passed
@ghost ghost added this to the Next milestone Sep 13, 2023
@mthalman mthalman deleted the sbrp-update branch September 13, 2023 17:34
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants