Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.8] Disallow RequiresLocationAttribute in more places in source #70133

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[17.8] Disallow RequiresLocationAttribute in more places in source #70133

merged 1 commit into from
Sep 28, 2023

Conversation

jjonescz
Copy link
Member

Resolves #70011.
Test plan: #68056

@jjonescz jjonescz added the New Feature - Ref Readonly Parameters `ref readonly` parameters label Sep 26, 2023
@jjonescz jjonescz added this to the 17.8 milestone Sep 26, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 26, 2023
@jjonescz jjonescz marked this pull request as ready for review September 26, 2023 14:12
@jjonescz jjonescz requested a review from a team as a code owner September 26, 2023 14:12
@jjonescz
Copy link
Member Author

@jcouv @AlekseyTs @dotnet/roslyn-compiler for reviews, thanks

@jjonescz
Copy link
Member Author

@dotnet/roslyn-compiler for a second review, thanks

AlekseyTs
AlekseyTs approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jjonescz jjonescz merged commit 904f294 into dotnet:release/dev17.8 Sep 28, 2023
25 checks passed
@jjonescz jjonescz deleted the 70011-RequiresLocationAttribute branch September 28, 2023 18:46
@allisonchou allisonchou mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv Awaiting requested review from jcouv

Assignees
No one assigned
Labels
Area-Compilers New Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jjonescz @RikkiGibson @AlekseyTs