Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection expressions: update better conversion from expression rule #70158

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Collection expressions: update better conversion from expression rule #70158

merged 4 commits into from
Oct 5, 2023

Conversation

cston
Copy link
Member

@cston cston commented Sep 27, 2023 •
edited by jcouv
Loading

From overload resolution:

  • C₁ and C₂ are collection expression conversions, and T₁ is a span_type with iteration type E₁, and T₂ is an array_or_array_interface_or_string_type with iteration type E₂, and E₁ is implicitly convertible to E₂

See LDM-2023-09-20
See LDM-2023-10-02

Relates to test plan #66418

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 27, 2023
@cston cston marked this pull request as ready for review September 27, 2023 23:10
@cston cston requested a review from a team as a code owner September 27, 2023 23:10
@jaredpar jaredpar added this to the 17.8 milestone Oct 2, 2023
@cston
Copy link
Member Author

cston commented Oct 3, 2023

@dotnet/roslyn-compiler, please review, thanks.

@cston cston changed the base branch from release/dev17.8 to features/CollectionLiterals October 5, 2023 16:50
@RikkiGibson RikkiGibson merged commit 4f7b164 into dotnet:features/CollectionLiterals Oct 5, 2023
21 of 25 checks passed
@cston cston deleted the span-vs-array branch October 5, 2023 20:30
@build-analysis build-analysis bot mentioned this pull request Oct 5, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@333fred 333fred

@RikkiGibson RikkiGibson

Labels
Area-Compilers New Feature - Collection Expressions untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.
4 participants
@cston @333fred @RikkiGibson @jaredpar