Ship Devkit dependencies as a nuget package to support directly including in the C# extension #70875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
3 tasks
…ding in the C# extension
dibarbet
commented
Nov 17, 2023
| @@ -33,7 +31,7 @@ private AssemblyLoadContextWrapper(AssemblyLoadContext assemblyLoadContext, Immu | |||
| _logger = logger; | |||
| } | |||
|
|
|||
| public static bool TryLoadExtension(string assemblyFilePath, string? sharedDependenciesPath, ILogger? logger, [NotNullWhen(true)] out Assembly? assembly) | |||
| public static bool TryLoadExtension(string assemblyFilePath, ILogger? logger, [NotNullWhen(true)] out Assembly? assembly) | |||
There was a problem hiding this comment.
@tmat would like you're review on this PR (but especially here). Seems unnecessary to load shared deps from devkit now. Smoke test on telemetry and hot reload works.
There was a problem hiding this comment.
Yeah, I think it'd even be incorrect to do so. We don't want to depend on versions of assemblies shipping in the DevKit.
tmat
reviewed
Nov 20, 2023
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/ServerConfigurationFactory.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Nov 20, 2023
| // Use the SharedDependenciesPath option as a proxy for whether or not devkit is running. | ||
| var isDevkitEnabled = !string.IsNullOrEmpty(serverConfiguration.SharedDependenciesPath); | ||
| // Check if the devkit extension is included to see if devkit is enabled. | ||
| var isDevkitEnabled = serverConfiguration.ExtensionAssemblyPaths.Any(path => path.Contains("Microsoft.VisualStudio.LanguageServices.DevKit.dll")); |
There was a problem hiding this comment.
I think this would be better: path => Path.GetFileName(path) == "..."
tmat
approved these changes
Nov 20, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See client side PR for details - dotnet/vscode-csharp#6681