Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate async methods #70941

Closed
wants to merge 1 commit into from

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #14467

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 22, 2023 17:53
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2023
@@ -66,7 +66,7 @@ protected override bool IsAsyncSupportingFunctionSyntax(SyntaxNode node)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view with whitespace off.

Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per design review #45287 (comment), we should not make a change to this behavior. The request in was reframed to #45368 and implemented in #48352, so no further changes are necessary.

@CyrusNajmabadi
Copy link
Member Author

This is still sensible to do. It just puts the method in the right default state for coding. And it works properly from the start. I've tried getting used to the 'add async when needed' approach, and it's often not sufficient, especially when making manual edits splicing and combining methods.

@sharwell
Copy link
Member

@CyrusNajmabadi that may be the case, but it would need to go to a team design review first since there is a clearly documented desired state that (in its current form) does not align with this pull request

@CyrusNajmabadi CyrusNajmabadi marked this pull request as draft December 8, 2023 17:18
@CyrusNajmabadi CyrusNajmabadi deleted the asyncGenMethod branch December 8, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "async" when using Generate Method on an await expression
3 participants