Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump msbuild logger in response to CI image upgrades #71125

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Bump msbuild logger in response to CI image upgrades #71125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0282ea8
Bump msbuild logger in response to CI image upgrades
dibarbet Dec 6, 2023
12aa8f3
Use repo version of msbuild logger in buildboss
dibarbet Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
<MicrosoftVisualStudioWorkspaceVSIntegrationVersion>17.1.11-preview-0002</MicrosoftVisualStudioWorkspaceVSIntegrationVersion>
<MicrosoftWin32PrimitivesVersion>4.3.0</MicrosoftWin32PrimitivesVersion>
<MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion>
<MSBuildStructuredLoggerVersion>2.1.858</MSBuildStructuredLoggerVersion>
<MSBuildStructuredLoggerVersion>2.2.100</MSBuildStructuredLoggerVersion>
<MDbgVersion>0.1.0</MDbgVersion>
<MonoOptionsVersion>6.6.0.161</MonoOptionsVersion>
<MoqVersion>4.10.1</MoqVersion>
Expand Down
7 changes: 0 additions & 7 deletions src/Tools/BuildBoss/BuildBoss.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@
<SignAssembly>false</SignAssembly>
<UseVSHostingProcess>false</UseVSHostingProcess>
<IsShipping>false</IsShipping>

<!--
Bumping MSBuildStructuredLoggerVersion for entire repo would move us to newer version of MSBuild Pacakge,
which no longer support netcoreapp3.1. Therefore we only change the version referenced here to get the binlog
checker to work for logs produced by newer MSBuild in CI without requiring product change.
-->
<MSBuildStructuredLoggerVersion>2.1.787</MSBuildStructuredLoggerVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed because we apparently set the version differently here. However this doesn't seem to make sense anymore - the repo was already on a higher version than this even before I bumped it again. So removed.

</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
Expand Down