Params Collections: Implement language version check. #71228
Conversation
dotnet-issue-labeler
bot
added
the
untriaged
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review. This is a fairly small change |
| var src1 = @" | ||
| public class Params | ||
| { | ||
| static public void Test1(params System.ReadOnlySpan<long> a) {} |
There was a problem hiding this comment.
Do we carry params-ness through to delegate natural types? Consider adding some variants of this test for delegate conversions as well, even if we don't, just to verify that behavior. #Resolved
There was a problem hiding this comment.
Do we carry params-ness through to delegate natural types?
At the moment this is done only for arrays. Expanding the behavior to other types is on my list to do.
Consider adding some variants of this test for delegate conversions as well,
I prefer to do that once "carry-over" part is implemented. But this is definitely a good scenario to cover.
There was a problem hiding this comment.
At the moment this is done only for arrays. Expanding the behavior to other types is on my list to do.
Gotcha, thanks.
|
@RikkiGibson, @dotnet/roslyn-compiler For the second review. This is a fairly small change |
AlekseyTs
merged commit 60a4581
into
dotnet:features/ParamsCollections
No description provided.