Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IDS_ParamsCollections to IDS_FeatureParamsCollections #72399

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1867,7 +1867,7 @@ private BoundExpression CreateMethodGroupConversion(SyntaxNode syntax, BoundExpr
}
else if (destination is AnonymousTypeManager.AnonymousDelegatePublicSymbol { CheckParamsCollectionsFeatureAvailability: true })
{
MessageID.IDS_ParamsCollections.CheckFeatureAvailability(diagnostics, syntax);
MessageID.IDS_FeatureParamsCollections.CheckFeatureAvailability(diagnostics, syntax);
}

Debug.Assert(conversion.UnderlyingConversions.IsDefault);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1588,7 +1588,7 @@ internal void BindDefaultArgumentsAndParamsCollection(
{
if (Compilation.SourceModule != parameters[paramsIndex].ContainingModule)
{
MessageID.IDS_ParamsCollections.CheckFeatureAvailability(diagnostics, node);
MessageID.IDS_FeatureParamsCollections.CheckFeatureAvailability(diagnostics, node);
}

var unconvertedCollection = new BoundUnconvertedCollectionExpression(node, ImmutableArray<BoundNode>.CastUp(collectionArgs)) { WasCompilerGenerated = true, IsParamsArrayOrCollection = true };
Expand Down
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/CSharpResources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -7857,7 +7857,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="IDS_LockObject" xml:space="preserve">
<value>Lock object</value>
</data>
<data name="IDS_ParamsCollections" xml:space="preserve">
<data name="IDS_FeatureParamsCollections" xml:space="preserve">
<value>params collections</value>
</data>
<data name="ERR_CantInferMethTypeArgs_DynamicArgumentWithParamsCollections" xml:space="preserve">
Expand Down
4 changes: 2 additions & 2 deletions src/Compilers/CSharp/Portable/Errors/MessageID.cs
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ internal enum MessageID
IDS_ImplicitIndexerInitializer = MessageBase + 12840,
IDS_LockObject = MessageBase + 12841,

IDS_ParamsCollections = MessageBase + 12900, // PROTOTYPE(ParamsCollections): pack numbers
IDS_FeatureParamsCollections = MessageBase + 12900, // PROTOTYPE(ParamsCollections): pack numbers
}

// Message IDs may refer to strings that need to be localized.
Expand Down Expand Up @@ -465,7 +465,7 @@ internal static LanguageVersion RequiredVersion(this MessageID feature)
case MessageID.IDS_StringEscapeCharacter:
case MessageID.IDS_ImplicitIndexerInitializer:
case MessageID.IDS_LockObject:
case MessageID.IDS_ParamsCollections:
case MessageID.IDS_FeatureParamsCollections:
return LanguageVersion.Preview;

// C# 12.0 features.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal sealed class AnonymousDelegatePublicSymbol : AnonymousTypeOrDelegatePub

/// <summary>
/// This member does not participate in equality because it is not reflecting any semantic aspect of the symbol.
/// It is only used to determine if we need to check for <see cref="MessageID.IDS_ParamsCollections"/>
/// It is only used to determine if we need to check for <see cref="MessageID.IDS_FeatureParamsCollections"/>
/// feature availability, which happens if this field is set to 'true'.
/// If in the process of merging equivalent types, the one with 'false' wins over the one with 'true',
/// that is fine, because that means that the feature availability check is performed on a
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1646,7 +1646,7 @@ void validateParamsType(BindingDiagnosticBag diagnostics)

if (collectionTypeKind != CollectionExpressionTypeKind.Array)
{
MessageID.IDS_ParamsCollections.CheckFeatureAvailability(diagnostics, ParameterSyntax);
MessageID.IDS_FeatureParamsCollections.CheckFeatureAvailability(diagnostics, ParameterSyntax);
}
}

Expand Down
10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.