Remove workspace option #72490
Merged
Remove workspace option #72490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 11, 2024
| @@ -90,21 +87,18 @@ internal class InProcOrRemoteHostAnalyzerRunner | |||
| public static async Task<ImmutableArray<Diagnostic>> GetSourceGeneratorDiagnosticsAsync(Project project, CancellationToken cancellationToken) | |||
| { | |||
| var options = project.Solution.Services.GetRequiredService<IWorkspaceConfigurationService>().Options; | |||
| if (!options.RunSourceGeneratorsInSameProcessOnly) | |||
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Mar 11, 2024
| // the contents. | ||
| Assert.Equal(syncWithRemoteServer, !gotException); | ||
| } | ||
| } |
There was a problem hiding this comment.
we had tests actually vvalidating that without this option that our host/oop get out of sync. since hte option is gone and both most be in sync, all the tests validate that.
dibarbet
approved these changes
Mar 11, 2024
sharwell
approved these changes
Mar 11, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option existed in case we discovered a major problem with OOP generation of SG docs and had to roll it back. So far we've had no problems, and hte new model ensures correctness between our hosts. So the option (And complexity around it) are being removed.