Add a unit test to ensure object initialisers supports completion in collection expressions #72515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection expressions
ghost
self-requested a review
as a 
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
|
|
||
| await VerifyItemExistsAsync(markup, "Start"); | ||
| await VerifyItemExistsAsync(markup, "End"); | ||
| await VerifyExclusiveAsync(markup, true); |
There was a problem hiding this comment.
in general, we would prfer that completion tests go into CompletionCommandHandlerTests. The provider tests are very broken (Since things can appear in them, and not show up in actual completion).
There was a problem hiding this comment.
think of thse as legacy tests we need to port over, but have no time to do so :)
CyrusNajmabadi
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72400
This issue was already fixed, but it was pointed out that it should still have a unit test so I am adding one just like the case in the issue.