ExternalAccess.Xaml fixes #72560
Merged
ExternalAccess.Xaml fixes #72560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced incompatible `CreateHoverResultAsync` with `CreateMarkdownContent` - Fixed XAML `DesciptionService` to show code examples in proper code blocks
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
|
@dibarbet This fixes the last place in EA.Xaml that was still exposing LSP Protocol types. |
dibarbet
approved these changes
Mar 15, 2024
|
@dibarbet It's all green. Would you mind merging when you get a moment? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateHoverResultAsyncwithCreateMarkdownContentDesciptionServiceto show code examples in proper code blocks