Fix potential exception in AssetProvider.SynchronizeAssetsAsync #72597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a perf fix I made last week, I assumed _assetCache wouldn't change underneath me during execution of SynchronizeAssetsAsync. That assumption is not true. Now, if the asset cache changes such that the missingChecksums array is no longer sufficient to hold all missing checksums, then grow the array capacity such that it can hold additional entries that might now be missing.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Mar 19, 2024
333fred
added a commit
that referenced
this pull request
Mar 20, 2024
* upstream/main: (1045 commits) Fix excessive compilation times due to speculative parsing after an incomplete string (#72565) Convert official pipeline to 1ES template (#72430) Fix #69628 Analyzer summary should show suppressor ID (#72569) Fix event hookup even when in a projection buffer Drop win32-ia32 language server support Remove workaround for .net7 r2r assembly loading issue remove unused usings Share compilation when generators don't produce any generated files Fix potential exception in AssetProvider.SynchronizeAssetsAsync (#72597) Fix Update __arglist.md (#72523) Improve code gen for concatenation of `string` and `char` (#71793) Reduce File I/O under the AnalyzerAssemblyLoader folder (#72412) Reduce allocations in AbstractTypeMap (#72588) disable diagnostics when solution crawler option is disabled disable diagnostics when solution crawler option is disabled better thread transitions Fix Add check Fix ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a perf fix I made last week, I assumed _assetCache wouldn't change underneath me during execution of SynchronizeAssetsAsync. That assumption is not true.
Now, if the asset cache changes such that the missingChecksums array is no longer sufficient to hold all missing checksums, then grow the array capacity such that it can hold additional entries that might now be missing.