Fix LSP File watching so it correctly reports the baseUri if there's a trailing slash #73203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
src/Features/LanguageServer/Protocol/Extensions/ProtocolConversions.cs
Outdated
Show resolved
Hide resolved
| // found at https://github.com/microsoft/vscode/blob/9e1974682eb84eebb073d4ae775bad1738c281f6/src/vscode-dts/vscode.d.ts#L2226 | ||
| // the baseUri should not end in a trailing separator, nor should it | ||
| // have any relative segmeents (., ..) | ||
| if (path[^1] == System.IO.Path.DirectorySeparatorChar) |
There was a problem hiding this comment.
every time we hand write some file path code, i die inside. :)
There was a problem hiding this comment.
get out of here with your sense and logic. TBH I was just trying to avoid any allocations but I'm guessing trimend will be efficient enough
|
@CyrusNajmabadi or @dibarbet PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.