Improve processing in FindRefs #73253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 27, 2024
| @@ -58,14 +58,6 @@ public void OnCompleted() | |||
| { | |||
| } | |||
|
|
|||
| public void OnFindInDocumentStarted(Document document) | |||
There was a problem hiding this comment.
FAR had a system to notify consumers "i'm startign a doc" and "i'm done with a doc". The original thinking was to use that for progress, to display which file we're looking at.
but:
- we never hooked this up to naything at all.
- this wouldn't be a good experience anyways, since we're extremely parallel. so this was removed entirely.
CyrusNajmabadi
commented
Apr 27, 2024
| @@ -107,17 +106,21 @@ public async ValueTask OnDefinitionFoundAsync(SymbolGroup group, CancellationTok | |||
| await context.OnDefinitionFoundAsync(definitionItem, cancellationToken).ConfigureAwait(false); | |||
| } | |||
|
|
|||
| public async ValueTask OnReferenceFoundAsync(SymbolGroup group, ISymbol definition, ReferenceLocation location, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
view with whitespcae off.
CyrusNajmabadi
commented
Apr 27, 2024
| @@ -44,7 +44,7 @@ public async Task FindBasesAsync(IFindUsagesContext context, Document document, | |||
| var (symbol, project) = symbolAndProjectOpt.Value; | |||
|
|
|||
| var solution = project.Solution; | |||
| var bases = await FindBaseHelpers.FindBasesAsync(symbol, solution, cancellationToken).ConfigureAwait(false); | |||
| var bases = FindBaseHelpers.FindBases(symbol, solution, cancellationToken); | |||
There was a problem hiding this comment.
a lot of FAR and helpers becamse sync. will explain how later in pr.
CyrusNajmabadi
commented
Apr 27, 2024
| @@ -73,8 +74,6 @@ public IStreamingProgressTracker ProgressTracker | |||
| // any of these. | |||
| public ValueTask OnStartedAsync(CancellationToken cancellationToken) => default; | |||
| public ValueTask OnCompletedAsync(CancellationToken cancellationToken) => default; | |||
| public ValueTask OnFindInDocumentStartedAsync(Document document, CancellationToken cancellationToken) => default; | |||
| public ValueTask OnFindInDocumentCompletedAsync(Document document, CancellationToken cancellationToken) => default; | |||
There was a problem hiding this comment.
FAR had a system to notify consumers "i'm startign a doc" and "i'm done with a doc". The original thinking was to use that for progress, to display which file we're looking at.
but:
we never hooked this up to naything at all.
this wouldn't be a good experience anyways, since we're extremely parallel. so this was removed entirely.
ToddGrun
reviewed
Apr 28, 2024
| @@ -54,22 +54,20 @@ public static partial class SymbolFinder | |||
| var sourceMember = await FindSourceDefinitionAsync(m, solution, cancellationToken).ConfigureAwait(false); | |||
| var bestMember = sourceMember ?? m; | |||
|
|
|||
| if (await IsOverrideAsync(solution, bestMember, symbol, cancellationToken).ConfigureAwait(false)) | |||
| { | |||
| if (IsOverride(solution, bestMember, symbol)) | |||
ToddGrun
reviewed
Apr 28, 2024
src/Workspaces/Core/Portable/FindSymbols/FindReferences/FindReferenceCache.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 28, 2024
| @@ -114,20 +180,13 @@ public Task FindReferencesAsync(ISymbol symbol, CancellationToken cancellationTo | |||
| // which is why we do it in this loop and not inside the concurrent project processing that happens | |||
| // below. | |||
| await symbolSet.InheritanceCascadeAsync(currentProject, cancellationToken).ConfigureAwait(false); | |||
| allSymbols = symbolSet.GetAllSymbols(); | |||
| var allSymbols = symbolSet.GetAllSymbols(); | |||
|
|
|||
| // Report any new symbols we've cascaded to to our caller. | |||
| await ReportGroupsAsync(allSymbols, cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
I assume this can't be moved into the parallel part of the computation?
There was a problem hiding this comment.
let me noodle on that. it would be clunkier. Fundamentally, the inheritance cascade is serial. The reporting of results it finds is... not that important. but the reporting does need to happen prior to any symbols for a group being fired.
ToddGrun
reviewed
Apr 28, 2024
src/Workspaces/Core/Portable/FindSymbols/FindReferences/FindReferencesSearchEngine.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 28, 2024
.../Portable/FindSymbols/FindReferences/FindReferencesSearchEngine_FindReferencesInDocuments.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 28, 2024
src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finders/AbstractReferenceFinder.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 28, 2024
| @@ -380,7 +376,7 @@ protected static Task FindDocumentsWithForEachStatementsAsync<TData>(Project pro | |||
| CancellationToken cancellationToken) | |||
| { | |||
| var document = state.Document; | |||
ToddGrun
reviewed
Apr 28, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.UnrootedSymbolSet.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 28, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.UnrootedSymbolSet.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what was done in #73249.