Move IsBuildOnlyDiagnostic to use a switch expression #73313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By suppressing CS8524, we can get a build-time diagnostic when we forget to update this, rather than getting a test failure that we often forget until CI throws.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
333fred
commented
May 2, 2024
jcouv
approved these changes
May 2, 2024
RikkiGibson
reviewed
May 2, 2024
RikkiGibson
reviewed
May 2, 2024
| or ErrorCode.ERR_InterceptsLocationDuplicateFile | ||
| or ErrorCode.ERR_InterceptsLocationFileNotFound | ||
| or ErrorCode.ERR_InterceptsLocationDataInvalidPosition | ||
| or ErrorCode.INF_TooManyBoundLambdas |
There was a problem hiding this comment.
I am curious if the code paths which process these are resilient against blowing the stack. Basically is there a chance that we add another error code here one day and the Mac leg starts failing :)
There was a problem hiding this comment.
Mac leg starts failing
mac leg is already failing for a long time :D - #70233
RikkiGibson
approved these changes
May 2, 2024
Co-authored-by: Rikki Gibson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By suppressing CS8524, we can get a build-time diagnostic when we forget to update this, rather than getting a test failure that we often forget until CI throws.