-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore drive casing when comparing on windows platforms #73380
Merged
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
36ae032
Add dynamic registration for razor and cshtml files
ryzngard 537b5f6
Ignore drive casing when comparing on windows platforms
ryzngard 4cfc4d4
Change path comparison
ryzngard b9a9dcc
Merge branch 'main' into hr_razor_dynamicsync
ryzngard 0522212
Move registration
ryzngard f0d4f62
Merge branch 'hr_razor_dynamicsync' into hr_razor_drivecasing
ryzngard 4c06ff7
Undo changes
ryzngard dea0154
Merge branch 'main' into hr_razor_drivecasing
ryzngard 6f2b9fa
Merge branch 'main' of https://github.com/dotnet/roslyn into hr_razor…
ryzngard ef6454c
Fix check
ryzngard 7834309
Merge branch 'main' into hr_razor_drivecasing
ryzngard fb5729c
Normalize section names
ryzngard 8f28cc6
Add tests
ryzngard 4df9f95
Also normalize pathToFile
ryzngard 2ab5d37
Update tests
ryzngard e550ae0
Update more tests
ryzngard 5235e76
Update src/Compilers/Core/Portable/CommandLine/AnalyzerConfig.cs
ryzngard b11b5f0
Update inlinedata
ryzngard 4fa2106
Merge branch 'hr_razor_drivecasing' of https://github.com/ryzngard/ro…
ryzngard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we have separate normalize helpers vs. putting them all in one method? Basically I'm wondering if there is ever a case where it's okay to call only some of these normalized methods but not othhers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding the section name storage from parsing only needs to call this one, while retrieval of options for a filepath should call both. @jjonescz is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's correct that calling just the one for section names fixes the bug at hand. But I agree with Jared that we could call both even for section names, I imagine that would fix some more inconsistencies. For example, a section
[*//*.cs]
doesn't match filea/b.cs
today probably. I'm not sure it should per editorconfig spec (if there is such a thing) though!If we are not going to do that in this PR, we should at least file an issue to follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy for issue + follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#73620