Avoid unnecessary full tree walks in the simplifier system #73473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
May 14, 2024
src/Workspaces/Core/Portable/Simplification/AbstractSimplificationService.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
May 14, 2024
| @@ -166,6 +165,9 @@ bool isNodeOrTokenOutsideSimplifySpans(SyntaxNodeOrToken nodeOrToken) | |||
| } | |||
|
|
|||
| return document; | |||
|
|
|||
| bool IsNodeOrTokenOutsideSimplifySpans(SyntaxNodeOrToken nodeOrToken) | |||
There was a problem hiding this comment.
can do later (it's already being touched in #73471)
ToddGrun
reviewed
May 14, 2024
| var hasImportsToSimplify = root != originalRoot; | ||
|
|
||
| if (hasImportsToSimplify) | ||
| { | ||
| document = document.WithSyntaxRoot(root); | ||
| semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false); | ||
| root = await semanticModel.SyntaxTree.GetRootAsync(cancellationToken).ConfigureAwait(false); | ||
| root = (TCompilationUnitSyntax)await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
yes. when we set the root, we get a new syntax tree with the root parented by that (that involves a fork of the red node, but it reuses the underlying green node).
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops us from:
to:
Note: there are much more wins from this as this basically drops practically every syntax node kind. All up this lowers us 25% from:
to: