[17.10] Disable nullable comparison optimization for decimals

[jjonescz]

Cherry-pick of #73536.
QB issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2060321

[kirsan31]

In what version of VS 17.10 this will be deployed?

[jjonescz]

In what version of VS 17.10 this will be deployed?

This is planned for VS 17.10.1, i.e., the next version

[cremor]

I assume a new SDK version with the fix will be released at the same time as VS 17.10.1?

[cremor]

So, has this been fixed in 17.10.1? Because the release notes page still mentions the known issue.
If it has been fixed, is it also fixed in SDK 8.0.301?

[jjonescz]

Sorry, it looks like the fix did not make it into SDK 8.0.301, it should be part of some future 8.0.3xx version. I think it should be fixed in VS 17.10.1 (if you build from inside VS).

[cremor]

Is it fixed in SDK 8.0.302?
If it is then I think the point should be removed from the known issues list.

[kirsan31]

17.10.3 already, and the bug still exist in known issues 🤷‍♂️
Can any one clarify?

[jjonescz]

Can any one clarify?

If you build from VS 17.10.1 and later versions, this bug should not be there. But if you have SDK 8.0.3xx (and build using dotnet build command for example), the bug is still there; should be fixed in 8.0.303. Sorry for any inconvenience.

[cremor]

But if you have SDK 8.0.3xx (and build using dotnet build command for example), the bug is still there; should be fixed in 8.0.303

TBH I find this quite irritating. The bug was so severe that it:

• Made it in the known issues list of Visual Studio
• Was fixed in just 2 days.
• Was released with a new Visual Studio update in just 8 days.

But still, now 6 weeks later, there is no SDK release with the fix. In my opinion, the SDK is way more important than VS because the SDK is what actually compiles our release software on build agents.

[kirsan31]

Can any one confirm that this was deployed in 8.0.303?

[jjonescz]

Can any one confirm that this was deployed in 8.0.303?

Yes, this fix is part of SDK 8.0.303.