Avoid unnecessary array+linq allocs in common case #73727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
May 26, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
May 27, 2024
| // the same text (for example, when GetOpenDocumentInCurrentContextWithChanges) is called. | ||
| // | ||
| // The use of GetRequiredState mirrors what happens in WithDocumentTexts | ||
| if (!SourceTextIsUnchanged(documentState, text)) |
There was a problem hiding this comment.
Yes. That definitely makes sense. I can tweak to that when I get home. Lmk if this is otherwise ok
3 tasks
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses large allocation here:
The issue is not the array allocation itself, it's that we're doing anything allocating for a very common case where we're called to update a document with the text it already points at. This can happen during things like GetOpenDocumentWithChanges:
In hte majority of cases, the doc will be updated to the content it already has. So bailing out immediately, without doing any work is beneficial.