Remove explicit GC calls in the asset cache #73752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 28, 2024
| { | ||
| for (var i = 0; i < 3; i++) | ||
| GC.Collect(); | ||
| } |
There was a problem hiding this comment.
this is a move of waht the product code used to do. i moved it here so test code dosen't have to update.
ToddGrun
reviewed
May 28, 2024
| @@ -138,42 +115,10 @@ private async Task CleanAssetsAsync() | |||
| while (!cancellationToken.IsCancellationRequested) | |||
| { | |||
| await CleanAssetsWorkerAsync(cancellationToken).ConfigureAwait(false); | |||
|
|
|||
| ForceGC(); | |||
There was a problem hiding this comment.
Never mind, expanded my search and there are other activities on this thread
| private static void ForceGC() | ||
| { | ||
| for (var i = 0; i < 3; i++) | ||
| GC.Collect(); |
There was a problem hiding this comment.
If this is being used for testing it's odd it isn't doing the WaitForPendingFinalizers that is often used....
There was a problem hiding this comment.
Yes. thsi is very odd.
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a holdover from our 32bit days where we needed to be much more aggressive about relinquishing memory. We do not need that now, and we want to let the normal GC do its thing.