Simplify fix-all code #73805
Merged
Simplify fix-all code #73805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
May 31, 2024
| /// the <see cref="FixAllState"/> in case that would be useful (for example if the <see | ||
| /// cref="IFixAllState.CodeActionEquivalenceKey"/> is used. | ||
| /// <para/> | ||
| /// Only one of these three overloads needs to be overridden if you want to customize behavior. |
ToddGrun
reviewed
May 31, 2024
| @@ -55,42 +51,24 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context) | |||
| if (declarationTypeToFix == null) | |||
| return; | |||
|
|
|||
| RegisterCodeFix(context, CSharpCodeFixesResources.Declare_as_nullable, GetEquivalenceKey(node, model)); | |||
| RegisterCodeFix(context, CSharpCodeFixesResources.Declare_as_nullable, GetEquivalenceKey(node)); | |||
akhera99
approved these changes
May 31, 2024
ToddGrun
reviewed
May 31, 2024
| @@ -108,29 +86,31 @@ static bool IsRemoteApiUsage(SyntaxNode node, SemanticModel model) | |||
| foreach (var diagnostic in diagnostics) | |||
| { | |||
| var node = diagnostic.Location.FindNode(getInnermostNodeForTie: true, cancellationToken); | |||
| MakeDeclarationNullable(editor, model, node, alreadyHandled, cancellationToken); | |||
| await MakeDeclarationNullableAsync( | |||
| document, model, editor, node, alreadyHandled, cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
true. but i'm ok here deferring that until we have some traces indicating benefit :)
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for a fix-all provider to force creating a semantic model (which also creates compilations/SG docs) if it doesn't need it.