Delay reporting of pattern-based using diagnostics #73850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
jcouv
force-pushed
the
using-diagnostics
branch
3 times, most recently
from
6074c5d
to
abbf35a
Compare
AlekseyTs
reviewed
Jun 7, 2024
AlekseyTs
reviewed
Jun 7, 2024
AlekseyTs
reviewed
Jun 7, 2024
src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAwaitUsingTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jun 7, 2024
|
Done with review pass (commit 1) |
|
Sorry, looks like CodeFlow broke on second commit :-/ |
|
@jcouv It looks like there are legitimate test failures. |
AlekseyTs
reviewed
Jun 11, 2024
AlekseyTs
reviewed
Jun 11, 2024
|
Consider including tests for scenarios from #72819. The adjusted test case is ref struct specific. |
|
Done with review pass (commit 4) |
|
@dotnet/roslyn-compiler for second review. Thanks |
chsienki
approved these changes
Jun 11, 2024
|
@jcouv It looks like there is a legitimate test failure |
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the reported scenario, we try to bind pattern-based first, but incorrectly report the diagnostics from that binding despite successfully binding via interface as fallback.
Regression from #72598
Fixes #73691
Fixes #72819