Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorconfig options enumerator refactoring #73907

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Editorconfig options enumerator refactoring #73907

merged 5 commits into from
Jun 10, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 8, 2024

Renames types from "generator" to "enumerator" as they do not generate, but rather enumerate the options.

Refactors the code a bit.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 8, 2024
@tmat tmat marked this pull request as ready for review June 8, 2024 16:38
@tmat tmat requested a review from a team as a code owner June 8, 2024 16:38
@tmat
Copy link
Member Author

tmat commented Jun 10, 2024

@CyrusNajmabadi @dotnet/roslyn-ide ptal

…onfigOptionsEnumerator.vb

Co-authored-by: Cyrus Najmabadi <[email protected]>
@tmat tmat enabled auto-merge (squash) June 10, 2024 19:41
@tmat tmat merged commit da99c65 into dotnet:main Jun 10, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 10, 2024
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants