Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required VS to 17.8. #73951

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jun 11, 2024

Building 17.8 is failing with the following error "SDK 8.0.101 requires VS 17.7 or higher". See https://dev.azure.com/dnceng/internal/_build/results?buildId=2470784&view=logs&j=b11b921d-8982-5bb3-754b-b114d42fd804&t=fb192a8b-e433-5fc8-e2b0-276ab015e7d5 (microsoft)

Fixes SigningValidation in the official build pipeline.

SDK 8.0.101 requires VS 17.7 or higher.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 11, 2024
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it passes CI who am I to judge

@JoeRobich JoeRobich merged commit 7dce3e2 into release/dev17.8 Jun 12, 2024
19 of 24 checks passed
@JoeRobich JoeRobich deleted the dev/jorobich/fix-17.8-official-build branch September 24, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants