Fix allow ref like types for synthesized TypeParameterSymbols in Ad-Hoc Delegates #74714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
|
Do we have a bug for this? |
|
See #74823 |
jjonescz
reviewed
Aug 27, 2024
| @@ -32,6 +32,40 @@ internal static void VerifyDiagnostics(string source, params DiagnosticDescripti | |||
| [CompilerTrait(CompilerFeature.LocalFunctions)] | |||
| public class LocalFunctionTests : LocalFunctionsTestBase | |||
| { | |||
| [Fact] | |||
| public void TestAdHocDelegateWithParams_NotAllowRefLikeTest() | |||
There was a problem hiding this comment.
It feels like this should be in a different file than LocalFunctionTests, for example RefStructInterfacesTests seems better.
There was a problem hiding this comment.
I didn't know where to define it - that would be a better place or something like "allowRefStructTests.cs"
|
|
||
| namespace Microsoft.CodeAnalysis.CSharp.Symbols | ||
| { | ||
| internal sealed class AllowsRefLikeTypeSymbolVisitor : SymbolVisitor |
There was a problem hiding this comment.
Are there any other cases than just params T[] that need to be handled specially?
- If yes, we should have tests for these cases.
- If no, we don't need a visitor, we could simply check just that one case.
There was a problem hiding this comment.
Not as far as I know
There was a problem hiding this comment.
Feel free to simplify the check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently synthesized TypeParameterSymbols for array params return AllowsRefLikeType=true, which is not true.
An array can not contain ref-structs.
fixes: #74823