Make host outputs public #74750
Merged
Make host outputs public #74750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change signature from (string, string) to (string, object) Shim EA implementations
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
chsienki
removed
the
untriaged
Closed
dotnet-policy-service
bot
added
the
Needs API Review
Open
3 tasks
|
@dotnet/roslyn-compiler for reviews please :) |
|
Looks like failures are real. |
jjonescz
reviewed
Aug 19, 2024
|
|
||
| var parseOptions = CSharpParseOptions.Default; | ||
| var compilation = CreateCompilation("class Compilation1{}", parseOptions: parseOptions); | ||
| GeneratorDriver driver = CSharpGeneratorDriver.Create([generator.AsSourceGenerator()], parseOptions: parseOptions, driverOptions: new GeneratorDriverOptions(IncrementalGeneratorOutputKind.Host)); |
There was a problem hiding this comment.
Consider testing that host outputs are present when another IncrementalGeneratorOutputKind is disabled
src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs
Show resolved
Hide resolved
jjonescz
reviewed
Aug 23, 2024
src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs
Outdated
Show resolved
Hide resolved
3 tasks
jjonescz
approved these changes
Aug 26, 2024
src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs
Outdated
Show resolved
Hide resolved
|
@333fred for a second review please :) |
333fred
approved these changes
Aug 27, 2024
src/Compilers/Core/Portable/SourceGeneration/Nodes/HostOutputNode.cs
Outdated
Show resolved
Hide resolved
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #74753