Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Collection Expression Conversion From Expression #74993

Merged
merged 24 commits into from
Sep 20, 2024
Merged

Better Collection Expression Conversion From Expression #74993

merged 24 commits into from
Sep 20, 2024
+1,663 −198

Conversation

333fred
Copy link
Member

@333fred 333fred commented Sep 4, 2024

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 4, 2024
@jaredpar jaredpar added this to the 17.12 milestone Sep 5, 2024
@333fred 333fred marked this pull request as ready for review September 10, 2024 17:13
@333fred 333fred requested a review from a team as a code owner September 10, 2024 17:13
@333fred
Copy link
Member Author

333fred commented Sep 10, 2024

@cston, @AlekseyTs for review. I've been able to successfully compile the BCL with no regressions; still working on VS, I've had a few infra issues during previous attempts.

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 19)

@333fred
Copy link
Member Author

333fred commented Sep 16, 2024

@AlekseyTs addressed feedback.

AlekseyTs
AlekseyTs approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 20)

@333fred 333fred enabled auto-merge (squash) September 20, 2024 20:54
@333fred 333fred merged commit 433ae40 into dotnet:main Sep 20, 2024
24 checks passed
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 17.12, Next Sep 20, 2024
@333fred 333fred deleted the feature/bcfce branch September 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv left review comments

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers New Feature - Collection Expressions New Feature - ParamsCollections untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
5 participants
@333fred @AlekseyTs @cston @jcouv @jaredpar