ILStrip: Rename namespace of Mono.Cecil to avoid clash #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
changed the title
akoeplinger
force-pushed
the
fix-cilstrip-namespace
branch
from
d3820ab
to
1c8ab37
Compare
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions. Rename the Mono.Cecil used here to avoid that clash.
akoeplinger
force-pushed
the
fix-cilstrip-namespace
branch
from
1c8ab37
to
3fc48e9
Compare
ViktorHofer
approved these changes
Sep 7, 2021
|
Presumably needed in release/6.0 as well? |
akoeplinger
added a commit
to akoeplinger/runtime-assets
that referenced
this pull request
Sep 7, 2021
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions. Rename the Mono.Cecil used here to avoid that clash. Backport of dotnet#169
akoeplinger
added a commit
that referenced
this pull request
Sep 7, 2021
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions. Rename the Mono.Cecil used here to avoid that clash. Backport of #169
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Sep 7, 2021
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions. Rename the Mono.Cecil used here to avoid that clash. Brings in dotnet/runtime-assets#169
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Sep 7, 2021
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions. Rename the Mono.Cecil used here to avoid that clash. Brings in dotnet/runtime-assets#169
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Sep 8, 2021
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions. Rename the Mono.Cecil used here to avoid that clash. Brings in dotnet/runtime-assets#169
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Sep 8, 2021
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions. Rename the Mono.Cecil used here to avoid that clash. Brings in dotnet/runtime-assets#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit a case where the ILStrip task assembly is IL-merged with a few other task assemblies on the Xamarin side which causes a clash because of trying to merge different Mono.Cecil versions.
Rename the Mono.Cecil used here to avoid that clash.