Skip to content

Commit

Permalink
Move one more 20H2 queue to server 2022 (#64919)
Browse files Browse the repository at this point in the history
* Move one more 20H2 queue to server 2022

Fix one more instance not covered by #64827.
This should fix the same failure in runtime-extra-platforms.

* Update IsIcuCompatiblePlatform
  • Loading branch information
sbomer authored Feb 7, 2022
1 parent ebcd332 commit 26c7d7d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion eng/pipelines/libraries/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ jobs:
- ${{ if or(ne(parameters.jobParameters.testScope, 'outerloop'), ne(parameters.jobParameters.runtimeFlavor, 'mono')) }}:
- ${{ if or(eq(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.10.Amd64.ServerRS5.Open
- Windows.10.Amd64.Server20H2.Open
- Windows.Amd64.Server2022.Open
- ${{ if or(ne(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.10.Amd64.Server19H1.ES.Open
- Windows.7.Amd64.Open
Expand Down
4 changes: 3 additions & 1 deletion src/libraries/System.Globalization/tests/IcuTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ namespace System.Globalization.Tests
public class IcuTests
{
private static bool IsIcuCompatiblePlatform => PlatformDetection.IsNotWindows ||
PlatformDetection.IsWindows10Version1903OrGreater;
(PlatformDetection.IsWindows10Version1903OrGreater &&
// Server core doesn't have icu.dll on SysWOW64
!(PlatformDetection.IsWindowsServerCore && PlatformDetection.IsX86Process));

[ConditionalFact(nameof(IsIcuCompatiblePlatform))]
public static void IcuShouldBeUsedByDefault()
Expand Down

0 comments on commit 26c7d7d

Please sign in to comment.