Skip to content

Commit

Permalink
Disable failing BinaryFormatter tests on ppc64le (#105022)
Browse files Browse the repository at this point in the history
  • Loading branch information
akoeplinger authored Jul 17, 2024
1 parent 8a7e38e commit 3f607bd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public abstract class BasicObjectTests<T> : SerializationTest<T> where T : ISeri

[Theory]
[MemberData(nameof(SerializableObjects))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/105020", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsPpc64leProcess))]
public void DeserializeStoredObjects(object value, TypeSerializableValue[] serializedData)
{
// Following call may change the contents of the fields by invoking lazy-evaluated properties.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public partial class BinaryFormatterTests
{
[Theory]
[MemberData(nameof(SerializableObjects_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/105020", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsPpc64leProcess))]
public void ValidateAgainstBlobs(object obj, TypeSerializableValue[] blobs)
=> ValidateAndRoundtrip(obj, blobs, isEqualityComparer: false);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle ass

[Theory]
[SkipOnCoreClr("Takes too long on Checked", ~RuntimeConfiguration.Release)]
[ActiveIssue("https://github.com/mono/mono/issues/15115", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/105020", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsPpc64leProcess))]
[MemberData(nameof(SerializableObjects_MemberData))]
public void ValidateAgainstBlobs(object obj, TypeSerializableValue[] blobs)
=> ValidateAndRoundtrip(obj, blobs, false);
Expand Down

0 comments on commit 3f607bd

Please sign in to comment.