Key should be non null (#5072)

dotnet · Jan 31, 2020 · 55d91ce · 55d91ce
1 parent 2355a10
commit 55d91ce
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...es/System.Security.Cryptography.Primitives/ref/System.Security.Cryptography.Primitives.cs b/...es/System.Security.Cryptography.Primitives/ref/System.Security.Cryptography.Primitives.cs
@@ -148,7 +148,7 @@ public abstract partial class HMAC : System.Security.Cryptography.KeyedHashAlgor
         protected HMAC() { }
         protected int BlockSizeValue { get { throw null; } set { } }
         public string HashName { get { throw null; } set { } }
-        public override byte[]? Key { get { throw null; } set { } }
+        public override byte[] Key { get { throw null; } set { } }
         public static new System.Security.Cryptography.HMAC Create() { throw null; }
         public static new System.Security.Cryptography.HMAC? Create(string algorithmName) { throw null; }
         protected override void Dispose(bool disposing) { }
@@ -171,7 +171,7 @@ public abstract partial class KeyedHashAlgorithm : System.Security.Cryptography.
     {
         protected byte[] KeyValue;
         protected KeyedHashAlgorithm() { }
-        public virtual byte[]? Key { get { throw null; } set { } }
+        public virtual byte[] Key { get { throw null; } set { } }
         public static new System.Security.Cryptography.KeyedHashAlgorithm Create() { throw null; }
         public static new System.Security.Cryptography.KeyedHashAlgorithm? Create(string algName) { throw null; }
         protected override void Dispose(bool disposing) { }

diff --git a/...ibraries/System.Security.Cryptography.Primitives/src/System/Security/Cryptography/HMAC.cs b/...ibraries/System.Security.Cryptography.Primitives/src/System/Security/Cryptography/HMAC.cs
@@ -49,7 +49,7 @@ public string HashName
             }
         }
 
-        public override byte[]? Key
+        public override byte[] Key
         {
             get => base.Key;
             set => base.Key = value;

diff --git a/...m.Security.Cryptography.Primitives/src/System/Security/Cryptography/KeyedHashAlgorithm.cs b/...m.Security.Cryptography.Primitives/src/System/Security/Cryptography/KeyedHashAlgorithm.cs
@@ -16,7 +16,7 @@ protected KeyedHashAlgorithm() { }
         public static new KeyedHashAlgorithm? Create(string algName) =>
             (KeyedHashAlgorithm?)CryptoConfigForwarder.CreateFromName(algName);
 
-        public virtual byte[]? Key
+        public virtual byte[] Key
         {
             get
             {
@@ -38,11 +38,11 @@ protected override void Dispose(bool disposing)
                 {
                     Array.Clear(KeyValue, 0, KeyValue.Length);
                 }
-                KeyValue = null;
+                KeyValue = null!;
             }
             base.Dispose(disposing);
         }
 
-        protected byte[]? KeyValue = null;
+        protected byte[] KeyValue = null!;
     }
 }