Fix signing in PR runs (#31926)

Make URCT copying unconditional to unblock installer tasks in debug mode. Thanks Tomas
dotnet · Feb 10, 2020 · 5c6f5b1 · 5c6f5b1
1 parent a4bc93f
commit 5c6f5b1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/eng/pipelines/installer/jobs/base-job.yml b/eng/pipelines/installer/jobs/base-job.yml
@@ -68,12 +68,8 @@ jobs:
       eq(parameters.isOfficialBuild, true),
       ne(parameters.crossrootfsDir, '')) }}
 
-  # TODO: (Consolidation) Enable test signing during PR validation. https://github.com/dotnet/runtime/issues/1026
-  #
-  # CoreCLR only produces the UCRT redist file in Release config. When the redist file isn't
-  # present, signing fails. For now, only sign in official builds which only run Release mode.
   - name: SignType
-    value: ''
+    value: test
 
   # Set up non-PR build from internal project
   - ${{ if eq(parameters.isOfficialBuild, true) }}:

diff --git a/src/coreclr/src/build.proj b/src/coreclr/src/build.proj
@@ -20,7 +20,7 @@
       <UcrtFilesToCopy Include="$(UniversalCRTSDKDir)Redist\ucrt\DLLs\$(BuildArch)\*.dll" />
     </ItemGroup>
 
-    <Copy Condition="'$(BuildType)'=='Release' AND '$(BuildArch)' != 'arm64'"
+    <Copy Condition="'$(BuildArch)' != 'arm64'"
         SourceFiles="@(UcrtFilesToCopy)"
         DestinationFolder="$(BinDir)Redist\ucrt\DLLs\$(BuildArch)" />
   </Target>