Skip to content

Commit

Permalink
[wasm] Change TrimMode setting for templates, and tests (#80639)
Browse files Browse the repository at this point in the history
* [wasm] Set TrimMode=full for templates

* [wasm] Remove TrimMode=partial default setting

.. and set TrimMode=partial for library tests.

* [wasm] don't set TrimMode explicitly for template projects. it will default to full now
  • Loading branch information
radical authored Jan 17, 2023
1 parent f3a0f4f commit 63f46d2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions eng/testing/tests.wasm.targets
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<ArchiveTests Condition="'$(WasmBuildingForNestedPublish)' == 'true'">false</ArchiveTests>
<BundleTestAppTargets>$(BundleTestAppTargets);BundleTestWasmApp</BundleTestAppTargets>
<DebuggerSupport Condition="'$(DebuggerSupport)' == '' and '$(Configuration)' == 'Debug'">true</DebuggerSupport>
<TrimMode Condition="'$(TrimMode)' == ''">partial</TrimMode>

<!-- set this when provisioning emsdk on CI -->
<EMSDK_PATH Condition="'$(EMSDK_PATH)' == '' and '$(ContinuousIntegrationBuild)' == 'true' and '$(MonoProjectRoot)' != ''">$([MSBuild]::NormalizeDirectory($(MonoProjectRoot), 'wasm', 'emsdk'))</EMSDK_PATH>
Expand Down
1 change: 0 additions & 1 deletion src/mono/wasm/build/WasmApp.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetOS>browser</TargetOS>
<RuntimeIdentifier>browser-wasm</RuntimeIdentifier>
<UseMonoRuntime>true</UseMonoRuntime>
<TrimMode Condition="'$(TrimMode)' == ''">partial</TrimMode>

<_WasmBuildCoreDependsOn>
_InitializeCommonProperties;
Expand Down

0 comments on commit 63f46d2

Please sign in to comment.