add units to http metrics (#90020)

dotnet · Aug 7, 2023 · e857642 · e857642
1 parent 302c44a
commit e857642
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs b/src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs
@@ -24,6 +24,7 @@ public MetricsHandler(HttpMessageHandler innerHandler, IMeterFactory? meterFacto
             // Meter has a cache for the instruments it owns
             _activeRequests = meter.CreateUpDownCounter<long>(
                 "http.client.active_requests",
+                unit: "{request}",
                 description: "Number of outbound HTTP requests that are currently active on the client.");
             _requestsDuration = meter.CreateHistogram<double>(
                 "http.client.request.duration",

diff --git a/...stem.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/SocketsHttpHandlerMetrics.cs b/...stem.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/SocketsHttpHandlerMetrics.cs
@@ -10,6 +10,7 @@ internal sealed class SocketsHttpHandlerMetrics(Meter meter)
     {
         public readonly UpDownCounter<long> OpenConnections = meter.CreateUpDownCounter<long>(
             name: "http.client.open_connections",
+            unit: "{connection}",
             description: "Number of outbound HTTP connections that are currently active or idle on the client.");
 
         public readonly Histogram<double> ConnectionDuration = meter.CreateHistogram<double>(