Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64/Sve: ConditionalSelect(LoadVector*NonFaultingSignExtend*) codegen #102904

Closed
kunalspathak opened this issue May 30, 2024 · 6 comments · Fixed by #105737
Closed

Arm64/Sve: ConditionalSelect(LoadVector*NonFaultingSignExtend*) codegen #102904

kunalspathak opened this issue May 30, 2024 · 6 comments · Fixed by #105737
Assignees
@a74nh
Labels
area-System.Runtime.Intrinsics arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@kunalspathak
Copy link
Member

As pointed out in https://github.com/dotnet/runtime/pull/102903/files#diff-f10507b9e232d4e19690c6a45d1372a35b663df21d62d2fb5011e2d360aa4a4aR49-R59, the LoadVector*NonFaultingSignExtend* and LoadVector*NonFaultingZeroExtend* APIs do not have explicit mask argument, which means they can be technically wrapped in ConditionalSelect. But under the hood, the instruction has Pg/Z semantics to load the values in vector. As such, if targetReg == falseReg, it does not play well because the instruction will overwrite the contents of falseReg and we will not get the desired result.
@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label May 30, 2024
@kunalspathak kunalspathak self-assigned this May 30, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 30, 2024
@kunalspathak
Copy link
Member Author

@dotnet/arm64-contrib

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 30, 2024
@vcsjones vcsjones added area-System.Runtime.Intrinsics and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 31, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@jeffhandley
Copy link
Member

@kunalspathak Should this be in scope for 9.0.0 or 10.0.0?

@kunalspathak
Copy link
Member Author

@kunalspathak Should this be in scope for 9.0.0 or 10.0.0?

Lets keep it in 9.0.0 for now

@kunalspathak kunalspathak added this to the 9.0.0 milestone Jul 20, 2024
@jeffhandley jeffhandley removed the untriaged New issue has not been triaged by the area owner label Jul 20, 2024
@kunalspathak
Copy link
Member Author

@a74nh @SwapnilGaikwad PTAL for .NET 9

@a74nh a74nh added the Priority:2 Work that is important, but not critical for the release label Jul 30, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

priority:2 for RC1 snap : Functionality issue

@a74nh a74nh mentioned this issue Aug 2, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 2, 2024
@amanasifkhalid amanasifkhalid mentioned this issue Aug 12, 2024
Closed
amanasifkhalid pushed a commit that referenced this issue Aug 13, 2024
@a74nh
ARM64-SVE: Fix conditional select for Zeroing predicates #102904 (#10…
329bff4 
…5737)
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@a74nh a74nh

Labels
area-System.Runtime.Intrinsics arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

ARM64-SVE: Fix conditional select for Zeroing predicates #102904 a74nh/runtime
5 participants
@vcsjones @jeffhandley @a74nh @SwapnilGaikwad @kunalspathak