Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the developer guide / building instructions #143

Closed
ViktorHofer opened this issue Nov 20, 2019 · 0 comments · Fixed by #251
Closed

Update the developer guide / building instructions #143

ViktorHofer opened this issue Nov 20, 2019 · 0 comments · Fixed by #251
Assignees
@ViktorHofer
Labels
documentation Documentation bug or enhancement, does not impact product or test code
Milestone
5.0.0

Comments

@ViktorHofer
Copy link
Member

We need to update the developer guide from corefx and make it more general purpose for the other repos as well.
@ViktorHofer ViktorHofer added the documentation Documentation bug or enhancement, does not impact product or test code label Nov 20, 2019
@ViktorHofer ViktorHofer added this to the 5.0 milestone Nov 20, 2019
@ViktorHofer ViktorHofer self-assigned this Nov 20, 2019
@ViktorHofer ViktorHofer mentioned this issue Nov 25, 2019
Merged
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Oct 12, 2020
@MichalStrehovsky
Mark System.Private assemblies as framework assemblies (dotnet#143)
9c38e5e 
We mostly need `[assembly: AssemblyMetadata(".NETFrameworkAssembly", "")]` because compiler checks for this in places. Versioning.targets adds a bunch of other stuff too.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Consolidate docs
1 participant
@ViktorHofer