Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApiCompat isn't running in CoreFx #27777

Closed
ericstj opened this issue Oct 30, 2018 · 0 comments · Fixed by dotnet/corefx#33152
Closed

ApiCompat isn't running in CoreFx #27777

ericstj opened this issue Oct 30, 2018 · 0 comments · Fixed by dotnet/corefx#33152
Assignees
@ericstj
Labels
area-Infrastructure-libraries bug
Milestone
3.0

Comments

@ericstj
Copy link
Member

ericstj commented Oct 30, 2018

After a combination of recent build changes the ResolveMatchingContract property is not set before we import <buildtools>\build.common.props > resolveContract.targets.

I didn't track down what caused this, but it's likely a combination of changes made by folks working on arcade conversion.
@ericstj ericstj self-assigned this Oct 30, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ericstj ericstj

Labels
area-Infrastructure-libraries bug
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Move resolveContract into corefx ericstj/corefx
2 participants
@ericstj @msftgits