This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move resolveContract into corefx #33152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
approved these changes
Oct 30, 2018
weshaggard
approved these changes
Oct 30, 2018
This moves resolveContract logic into corefx. It also fixes API compat which hasn't been running for some time due to ResolveMatchingContract property being set to let to sequence the target.
ericstj
force-pushed
the
resolveContract
branch
from
637400b
to
cbf7774
Compare
|
Test Windows x86 Release Build |
|
Test Windows x64 Debug Build |
|
test UWP NETNative x86 Release Build |
|
test Packaging All Configurations x64 Debug Build |
|
all these builds failed with timeouts from jenkins. |
We only want to add the contract item when building source projects.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Move resolveContract into corefx This moves resolveContract logic into corefx. It also fixes API compat which hasn't been running for some time due to ResolveMatchingContract property being set to let to sequence the target. * Fix System.Drawing.Design.Primitives reference * Fix resolveContract convention We only want to add the contract item when building source projects. Commit migrated from dotnet/corefx@271ed1b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves resolveContract logic into corefx. It also fixes API compat which
hasn't been running for some time due to ResolveMatchingContract property
being set too late to sequence the target.
Fixes #33151
We should be very careful about merging PRs with public API at the moment, as well as merging any PRs after this goes in if the results are stale.