Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to AzDO and Support testing changes in mirror #47328

Closed
4 tasks
hoyosjs opened this issue Jan 22, 2021 · 8 comments
Closed
4 tasks

Add support to AzDO and Support testing changes in mirror #47328

hoyosjs opened this issue Jan 22, 2021 · 8 comments

Comments

@hoyosjs
Copy link
Member

hoyosjs commented Jan 22, 2021

Description

This could help test some set of changes that can only be done with internal infrastructure. For this:

  • Audit different YMLs. There's a bunch of steps that need to be excluded on internal, and some that are conditioned on not being public and not PR, we might just need to turn that to just not public.
  • Add internal queues for Helix, add creator, and helix token needed for this.
  • Work with dnceng as a bunch of these queues have reduced capacity that won't scale to runtime's requirements.
  • Ensure branches have an appropriate policy pointing to a new build def - the PR definition in internal. Replicate this per branch that needs to support this.
@ghost
Copy link

ghost commented Jan 22, 2021

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This could help test some set of changes that can only be done with internal infrastructure. For this:

  • Audit different YMLs. There's a bunch of steps that need to be excluded on internal, and some that are conditioned on not being public and not PR, we might just need to turn that to just not public.
  • Add internal queues for Helix, add creator, and helix token needed for this.
  • Work with dnceng as a bunch of these queues have reduced capacity that won't scale to runtime's requirements.
  • Ensure branches have an appropriate policy pointing to a new build def - the PR definition in internal. Replicate this per branch that needs to support this.
Author: hoyosjs
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 22, 2021
@ViktorHofer
Copy link
Member

cc @dotnet/runtime-infrastructure

@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Feb 23, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Feb 23, 2021
@ViktorHofer
Copy link
Member

We definitely need this feature to service 6.0 efficiently. Hence adding blocking-release label and moving to 6.0.

@joperezr
Copy link
Member

@ViktorHofer I'm trying to find places where I can help with 6.0 issues, do you have this one assigned to anybody? Is there anything I can help out with this one?

@hoyosjs
Copy link
Member Author

hoyosjs commented Sep 15, 2021

@joperezr This one is not yet assigned. I thing a good start is we have a ton of places that do evaluations in yaml of the sort of (if not in internal and not a PR). We need to change it so that steps that are build-like are able to run on internal PRs for security patches. Right now PRs don't validate even builds. That'd be a huge step forward.

@ViktorHofer
Copy link
Member

What Juan said. Would be great if you could pick this one up. The deadline for this task is a soft one as it doesn't impact the initial release but the following servicing releases.

@jeffhandley jeffhandley modified the milestones: 6.0.0, 6.0.x Nov 22, 2021
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Feb 19, 2022
akoeplinger pushed a commit that referenced this issue Feb 21, 2022
Addresses #47328

This allows to run tests when submitting PRs in AzDO.
@akoeplinger
Copy link
Member

#65603 addressed this for main and we have a backport for release/6.0 here: #65526

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 21, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 11, 2022
@akoeplinger
Copy link
Member

This seems to be implemented now, we have PR support in internal AzDO.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

5 participants