Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm][AOT] System.NotImplementedException : The method or operation is not implemented. #49229

Closed
1 task
mdh1418 opened this issue Mar 5, 2021 · 1 comment · Fixed by #49402
Closed
1 task

[Wasm][AOT] System.NotImplementedException : The method or operation is not implemented. #49229

mdh1418 opened this issue Mar 5, 2021 · 1 comment · Fixed by #49402
Labels
arch-wasm WebAssembly architecture area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner

Comments

@mdh1418
Copy link
Member

mdh1418 commented Mar 5, 2021 •
edited
Loading

In effort to run library tests with AOT compilation and EnableAggressiveTrimming enabled on CI #48226 these errors are hit.

  • System.NotImplementedException : The method or operation is not implemented.
    System.Collections.Concurrent.Tests log
    System.Collections.Tests log
    System.Net.Primitives.Functional.Tests log
    Microsoft.Extensions.Configuration.Binder.Tests log
    System.Globalization.Tests log

Repro:
Check out changes in
4f17c4e without this, many tests are not discovered.
4e7ab85 this one helps avoid some AOT compilation errors with this exception filter. There shouldn't be exception filter issues anymore.

./build.sh -os Browser -arch wasm -c Release
./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/<path-to-test-proj>
@ghost
Copy link

ghost commented Mar 5, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In effort to run library tests with AOT compilation and EnableAggressiveTrimming enabled on CI #48226 these errors are hit.

  • System.NotImplementedException : The method or operation is not implemented.
    System.Collections.Concurrent.Tests log
    System.Collections.Tests log
    System.Net.Primitives.Functional.Tests log
    Microsoft.Extensions.Configuration.Binder.Tests log
    System.Globalization.Tests log

Repro:
Check out changes in https://github.com/steveisok/runtime/tree/build-wasm-aot-helix
./build.sh -os Browser -arch wasm -c Release
./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/<path-to-test-proj>

Author: mdh1418
Assignees: -
Labels:

arch-wasm, area-Infrastructure-libraries
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 5, 2021
@mdh1418 mdh1418 mentioned this issue Mar 5, 2021
Closed
@vargaz vargaz mentioned this issue Mar 10, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 10, 2021
vargaz added a commit to vargaz/runtime that referenced this issue Mar 10, 2021
@vargaz
[mono] Fix the emission of EnumEqualityComparer instances into the co…
3914bd8 
…rlib AOT image.

Add a few dummy enums to the Mono namespace in corlib, and use them
to create valid EnumEqualityComparer instances. Also make sure the
instances are actually emitted and not replaced by gsharedvt instances.

Fixes dotnet#49229.
vargaz added a commit that referenced this issue Mar 10, 2021
@vargaz
[mono] Fix the emission of EnumEqualityComparer instances into the co…
60dc59b 
…rlib AOT image. (#49402)

Add a few dummy enums to the Mono namespace in corlib, and use them
to create valid EnumEqualityComparer instances. Also make sure the
instances are actually emitted and not replaced by gsharedvt instances.

Fixes #49229.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mono] Fix the emission of EnumEqualityComparer instances into the co… vargaz/runtime
1 participant
@mdh1418