SerialStream doesn't override memory-based Read-/WriteAsync methods

[ViktorHofer]

When adding a NetCoreAppCurrent configuration to System.IO.Ports, roslyn warns that SerialStream's memory-based ReadAsync and WriteAsync methods aren't overridden. I was unsure if this requires api-approval so I'm filing this issue.

/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]
/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'WriteAsync' but does not override memory-based 'WriteAsync'. Consider overriding memory-based 'WriteAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]

cc @adamsitnik @carlossanlop @jozkee @jeffhandley

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

When adding a NetCoreAppCurrent configuration to System.IO.Ports, roslyn warns that SerialStream's memory-based ReadAsync and WriteAsync methods aren't overridden. I was unsure if this requires api-approval so I'm filing this issue.

/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]
/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'WriteAsync' but does not override memory-based 'WriteAsync'. Consider overriding memory-based 'WriteAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]

cc @adamsitnik @carlossanlop @jozkee @jeffhandley

Author:	ViktorHofer
Assignees:	-
Labels:	area-System.IO
Milestone:	-

[stephentoub]

I was unsure if this requires api-approval so I'm filing this issue.

No approval required.

[adamsitnik]

@ViktorHofer do you intend to work on it? If not, could please mark it as up-for-grabs and remove your assignment?

[i3arnon]

@adamsitnik Should I take this to mean there's an interest in implementing the ReadAsync & WriteAsync overloads (memory and array based) for the Windows version of SerialStream as well?

[adamsitnik]

Should I take this to mean there's an interest in implementing the ReadAsync & WriteAsync overloads (memory and array based) for the Windows version of SerialStream as well?

I've reconsidered that and most probably we should not do that for Windows as of now. The main reason is that testing this particular library is really hard and it would be easy to introduce a bug to the product. I am going to close both issues. @i3arnon thanks!