Infrastructure - Rollout (July 2021) #55281
Comments
|
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
dotnet-issue-labeler
bot
added
the
untriaged
ViktorHofer
added
area-Infrastructure
and removed
untriaged
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsOverviewWe use this issue to announce planned Infrastructure changes that will impact the developer workflow in
Archive
|
Anipik
added a commit
that referenced
this issue
Jul 22, 2021
* Update SDK to 6.0 Preview 5 Part of #55281 * Enable COM support to work around missing symbols in tests * Update eng/testing/linker/project.csproj.template * Disable the workload targets * Disable workloads for wasm builds For in-tree builds, and tests we don't want to use workloads from dotnet being used to build these. For the projects being built on the build machine, we can disable them via `Directory.Build.props`, and wasm's InTree/LocalBuild props. But for projects that get built on helix, eg. the runtime tests, we are setting the property values as environment variables. * Fix setting envvars for disabling workloads * Another attempt to fix wasm tests In preview5, the workload manifest overrides `$(UsingBrowserRuntimeWorkload)` setting, so pass it on the command line. ``xml <PropertyGroup Condition="'$(RuntimeIdentifier)' == 'browser-wasm'"> <UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload> <UsingBrowserRuntimeWorkload Condition="'$(UsingBrowserRuntimeWorkload)' == ''" >$(WasmNativeWorkload)</UsingBrowserRuntimeWorkload> </PropertyGroup> ``` * Fix host tests after upgrade to P5 In P5 we don't generate .runtimeconfig.dev.json anymore. Some tests started to fail because they relied on the .runtime.dev.json to include local nuget cache in the probing paths. I changed one of those tests to force-generate .runtimeconfig.dev.json as for the tested scenario it seems to make sense. For the other test I modified it to copy the necessary dependency into the right location instead. * Fix up reflection to private FileStatus field * Disable workload resolver for wasm.build.tests, EMSDK run * Disable workloads for wasm with MSBuildEnableWorkloadResolver=false everywhere * remove linker workaround * [wasm] Remove args unnecessary for disabling workloads * Pass MSBuildEnableWorkloadResolver property to individual trimming projects Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]> Co-authored-by: Santiago Fernandez Madero <[email protected]> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Ankit Jain <[email protected]> Co-authored-by: vitek-karas <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Anirudh Agnihotry <[email protected]>
mmitche
pushed a commit
that referenced
this issue
Jul 23, 2021
* Update SDK to 6.0 Preview 6 Part of #55281 * Enable COM support to work around missing symbols in tests * Update eng/testing/linker/project.csproj.template * Disable the workload targets * Disable workloads for wasm builds For in-tree builds, and tests we don't want to use workloads from dotnet being used to build these. For the projects being built on the build machine, we can disable them via `Directory.Build.props`, and wasm's InTree/LocalBuild props. But for projects that get built on helix, eg. the runtime tests, we are setting the property values as environment variables. * Fix setting envvars for disabling workloads * Another attempt to fix wasm tests In preview5, the workload manifest overrides `$(UsingBrowserRuntimeWorkload)` setting, so pass it on the command line. ``xml <PropertyGroup Condition="'$(RuntimeIdentifier)' == 'browser-wasm'"> <UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload> <UsingBrowserRuntimeWorkload Condition="'$(UsingBrowserRuntimeWorkload)' == ''" >$(WasmNativeWorkload)</UsingBrowserRuntimeWorkload> </PropertyGroup> ``` * Fix host tests after upgrade to P5 In P5 we don't generate .runtimeconfig.dev.json anymore. Some tests started to fail because they relied on the .runtime.dev.json to include local nuget cache in the probing paths. I changed one of those tests to force-generate .runtimeconfig.dev.json as for the tested scenario it seems to make sense. For the other test I modified it to copy the necessary dependency into the right location instead. * Fix up reflection to private FileStatus field * Disable workload resolver for wasm.build.tests, EMSDK run * Disable workloads for wasm with MSBuildEnableWorkloadResolver=false everywhere * remove linker workaround * [wasm] Remove args unnecessary for disabling workloads * Pass MSBuildEnableWorkloadResolver property to individual trimming projects Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]> Co-authored-by: Santiago Fernandez Madero <[email protected]> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Ankit Jain <[email protected]> Co-authored-by: vitek-karas <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Anirudh Agnihotry <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Overview
We use this issue to announce planned Infrastructure changes that will impact the developer workflow in
dotnet/runtime. Changes will be merged on TBD.Archive
The text was updated successfully, but these errors were encountered: